Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile picture feature #7995

Conversation

UdaySagar-Git
Copy link
Contributor

@UdaySagar-Git UdaySagar-Git commented Jun 7, 2024

Proposed Changes

backend pr : ohcnetwork/care#2253

Screen.Recording.2024-06-08.at.11.28.01.AM.mov

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@UdaySagar-Git UdaySagar-Git requested a review from a team as a code owner June 7, 2024 07:08
Copy link

vercel bot commented Jun 7, 2024

@UdaySagar-Git is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

<>
<div className="flex flex-1 items-center justify-center rounded-lg">
<img
src={imgSrc}

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
@UdaySagar-Git UdaySagar-Git mentioned this pull request Jun 11, 2024
12 tasks
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 19, 2024
@UdaySagar-Git
Copy link
Contributor Author

@rithviknishad can you please remove stale label

@github-actions github-actions bot removed the stale label Jun 23, 2024
@nihal467
Copy link
Member

@khavinshankar can you review it once

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @UdaySagar-Git, mostly looks good, just some minor refactors

src/Components/Common/Sidebar/SidebarUserCard.tsx Outdated Show resolved Hide resolved
src/Components/Users/ProfilePicUploadModal.tsx Outdated Show resolved Hide resolved
src/Components/Users/ProfilePicUploadModal.tsx Outdated Show resolved Hide resolved
src/Components/Users/ProfilePicUploadModal.tsx Outdated Show resolved Hide resolved
src/Components/Users/ProfilePicUploadModal.tsx Outdated Show resolved Hide resolved
src/Components/Users/ProfilePicUploadModal.tsx Outdated Show resolved Hide resolved
src/Components/Users/ProfilePicUploadModal.tsx Outdated Show resolved Hide resolved
src/Components/Users/ProfilePicUploadModal.tsx Outdated Show resolved Hide resolved
@UdaySagar-Git
Copy link
Contributor Author

@khavinshankar made changes accordingly. Can you review it once?

@nihal467
Copy link
Member

nihal467 commented Jul 8, 2024

@UdaySagar-Git follow-up on the ongoing discussion on your related backend PR

Copy link

github-actions bot commented Aug 1, 2024

👋 Hi, @UdaySagar-Git,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 1, 2024
@nihal467
Copy link
Member

nihal467 commented Aug 7, 2024

image

  • we need to manually reload the entire page, to view the uploaded profile, once the upload is successful. it shouldn't be the behavior, once the upload is complete, we should be able to see the profile picture without manual reload

@nihal467
Copy link
Member

nihal467 commented Aug 7, 2024

@UdaySagar-Git can you fix the merge conflict in this PR, and the test & lint failure in the related backend PR

CC: @gigincg

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Aug 16, 2024
@UdaySagar-Git
Copy link
Contributor Author

@nihal467 done !

@nihal467
Copy link
Member

nihal467 commented Sep 10, 2024

the PR testing is on hold, as the backend PR is failing test @UdaySagar-Git can you fix it , so we can get it for review

@gigincg
Copy link
Member

gigincg commented Sep 23, 2024

@sainak Can you update the issue here? I believe you've been working on this?

@gigincg
Copy link
Member

gigincg commented Sep 23, 2024

@nihal467 Can you expedite testing this? The backend has been merged.

@nihal467
Copy link
Member

nihal467 commented Sep 24, 2024

image
image

  • The profile picture upload functionality is not working and it's throwing 404 in the frontend

@gigincg @sainak @UdaySagar-Git @rithviknishad

@ohcnetwork ohcnetwork deleted a comment from netlify bot Sep 24, 2024
@ohcnetwork ohcnetwork deleted a comment from netlify bot Sep 24, 2024
@sainak sainak closed this Sep 24, 2024
@sainak sainak reopened this Sep 24, 2024
@sainak sainak closed this Sep 24, 2024
@sainak sainak mentioned this pull request Sep 24, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature : Allow users to add profile picture in care platform
6 participants